Remove an arbitrary sleep of 500 milliseconds. #1106
Conversation
The code below already attempts to take the messages for up to 10 seconds, so there is no reason for this wait. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
CI:
|
Signed-off-by: Chris Lalancette <[email protected]>
|
So it turns out that we actually do indeed need this 500 millisecond timeout. The point of the test is to test that we are only taking 3 of the messages when 5 are available. And for that, we need to make sure the 5 are actually available, which this 500 millisecond sleep (mostly) accomplishes. Honestly, though, what we really need is another API to tell us when we have 5 subscription messages available to take. That way we can just wait until that happens, and then get rid of the sleep. Since that would involve work at the RMW layer, I decided to just add a TODO to this effect. I don't love it, but at least we won't wonder why this is in here again. |
Opened issue describing that feature: #1109 Closing for now. |
The code below already attempts to take the messages for up to 10 seconds, so there is no reason for this wait.